Hey @cp-Coder , how about u create issues for the next 4 , from assetbed to consultationbed and link them in EPIC issue. So that I can work on them. 😊

https://github.com/coronasafe/care/issues/1385#issuecomment-1597443232

@vigneshhari @sainak @rithviknishad Added tests , Please Review!!

https://github.com/coronasafe/care/pull/1318#issuecomment-1591888745

Creating Tests for the whole code base is itself a huge task. So, Lemme know if I can make some part of contributions to this issue.

https://github.com/coronasafe/care/issues/1367#issuecomment-1587789387

@vigneshhari This is a PR, I 've created Earlier. Closed the old one. I added the tests . Please Review it!

https://github.com/coronasafe/care/pull/1370#issuecomment-1587781049

> You could have gotten away without mocking in these tests by using the update method of the django queryset ( they do not invoke the save methods and the created timestamps can be added manually "to my knowledge" ), even in this case, we are not mocking the database interactions, we are just mocking the time method. In almost all cases we would not want to mock the database, the database is what we are usually testing against. mocking is useful when there is an external service involved, like an SMS API or an integration with an API, in our unit tests we mock all the responses they can give ( success, failure, exception ) and test if the function we wrote handles every case correctly. Yaa ik that i haven't mocked any database interactions in the pushed code . I just asked it coz I first wrote the test by mocking database interactions, later i realised that isn't a gud idea. So i changed it. Thanks for sharing ur opinion. :smile:

https://github.com/coronasafe/care/pull/1328#issuecomment-1585163250

> @mathew-alex are S3 objects versioned in any deployment ? Hey I have gone through the code base quite a few times, wherever s3 configs or s3 methods made use of. No where Versioning details are mentioned. if versioning exists, it has to dealt while creation and retrieving of objects. So, ig none of our existing deployments are using versioned s3 buckets.

https://github.com/coronasafe/care/pull/1329#issuecomment-1585153772

@sainak Please review this

https://github.com/coronasafe/care/pull/1344#issuecomment-1581043770

@sainak Review please

https://github.com/coronasafe/care/pull/1329#issuecomment-1580949272

> @yaswanthsaivendra also could you prefix the issue numbers with "Fixes" or other linking keywords? My bad, I did all changes in single commit 😮‍💨. Referenced the changes in each task.

https://github.com/coronasafe/care/pull/1344#issuecomment-1574846047

> You are performing `<QuerySet>.delete()`. However, we've overridden the `<Instance>.delete()` to soft delete only. Would `<QuerySet>.delete()` call the overridden `delete` method and soft delete or does it hard delete? 🤦😅 hard delete, made changes to soft delete

https://github.com/coronasafe/care/pull/1344#issuecomment-1574845725

@rithviknishad Review please!

https://github.com/coronasafe/care/pull/1344#issuecomment-1574414851

Updated the code - to make bulk delete from s3, thereby reducing the number of api requests.

https://github.com/coronasafe/care/pull/1329#issuecomment-1574319921

@rithviknishad @vigneshhari review pls

https://github.com/coronasafe/care/pull/1329#issuecomment-1573272503

> @yaswanthsaivendra there are no changes in this pr you should create a new branch for every pull request sorry, I messed a bit. Pushed the changes Now. The worst thing, I did at the start is making changes in my master branch which leads to all this mess in the commits. Will avoid it in my further prs.

https://github.com/coronasafe/care/pull/1310#issuecomment-1572007187

Hey @rithviknishad , May ik what kind of query profiling you wanted to achieve. Ig , we already sql query calculation with the help of `django_debug_toolbar` rgt. Isn't that sufficient??

https://github.com/coronasafe/care/issues/1321#issuecomment-1569932968

> i want to resolve this issue, can i start ? No this one is still need to be discussed. Meanwhile , you can work on other issues.

https://github.com/coronasafe/care/issues/1326#issuecomment-1569929154

@rithviknishad , @vigneshhari Please review!!

https://github.com/coronasafe/care/pull/1328#issuecomment-1568356094

Hello team, Lemme know if its a relevant issue, if so I would like to work upon it!

https://github.com/coronasafe/care/issues/1326#issuecomment-1567520778

Hey , i would like to take up this one. As far i understand, we would need to create a periodic_task using celery that would run maybe every midnight to delete all the notifications that are older than 90 days. but can we specify a few things for me, - Like what would be a great place to create this scheduler function(maybe inside a new file - `care/facility/tasks/notification/delete_older_notifications.py`)?? - period/Time to run the task(maybe every midnight)?? - I cant see a `created_at` field so do we need to decide this 90 days older on basis upon `read_at` field which exists in Notification table or add a `created_at` field to the table??

https://github.com/coronasafe/care/issues/1320#issuecomment-1567462513

Is this issue still relevant, can I take up this one?? And as far I understand 2nd part of it, It requires to create a seperate through table ConsultationBedAsset with the schema of something like this, ConsultationBedAsset: consultation_bed - ForeignKey asset - ForeignKey but i didn't get the purpose of BedFlag through table . can u explain?

https://github.com/coronasafe/care/issues/1103#issuecomment-1566197659

Hey @sainak , I made the necessary changes , can u review it please!

https://github.com/coronasafe/care/pull/1310#issuecomment-1565424239

@sainak UserAssingedSerializer is used at 2 places. 1. in FacilityUserViewSet, where I have made the changes to prefetch the skills. 2. in [PatientConsulationSerializer](https://github.com/coronasafe/care/blob/7d14e41251787fe1bbb952ac22278f998b86b24a/care/facility/api/serializers/patient_consultation.py#L68) here i am not sure how it can be done. Can u suggest , what can be done here?

https://github.com/coronasafe/care/pull/1310#issuecomment-1564941244

@rithviknishad I have created a PR (#1310 ) for this issue. please review it!

https://github.com/coronasafe/care/issues/1189#issuecomment-1560871888